refactor multi test set datasets; add seq id test splits to GO #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amorehead
reviewed
Feb 5, 2024
amorehead
reviewed
Feb 5, 2024
| @@ -518,7 +530,7 @@ def get(self, idx: int) -> Data: | |||
| :return: PyTorch Geometric Data object. | |||
| """ | |||
| if self.in_memory: | |||
| return self._batch_format(self.data[idx]) | |||
| return self._batch_format(copy.deepcopy(self.data[idx])) | |||
There was a problem hiding this comment.
Does this lead to one of the performance enhancements we discussed previously?
There was a problem hiding this comment.
No noticeable delta but it makes me feel better about some of the gotchas here: https://alecstashevsky.com/post/on-the-fly-augmentation-with-pytorch-geometric-and-lightning-what-tutorials-dont-teach/
|
Besides the two comments above, LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setupin base datamodule to avoid setting up all datasets at once